bitkeeper revision 1.1632 (429ebf12k6wKnt6NCp_ccTvyXrINWg)
authorkaf24@firebug.cl.cam.ac.uk <kaf24@firebug.cl.cam.ac.uk>
Thu, 2 Jun 2005 08:10:58 +0000 (08:10 +0000)
committerkaf24@firebug.cl.cam.ac.uk <kaf24@firebug.cl.cam.ac.uk>
Thu, 2 Jun 2005 08:10:58 +0000 (08:10 +0000)
skb_copy_bits() can return an err, so have netif_be_start_xmit()
crash informatively.
Signed-off-by: Nivedita Singhvi <niv@us.ibm.com>
linux-2.6.11-xen-sparse/drivers/xen/netback/netback.c

index 6b69decbc0dacaa2423715715ab751dfda646209..02f0c2fc5150fc0d0e223874656035f5389b03b0 100644 (file)
@@ -153,7 +153,8 @@ int netif_be_start_xmit(struct sk_buff *skb, struct net_device *dev)
             goto drop;
         skb_reserve(nskb, hlen);
         __skb_put(nskb, skb->len);
-        (void)skb_copy_bits(skb, -hlen, nskb->data - hlen, skb->len + hlen);
+        if (skb_copy_bits(skb, -hlen, nskb->data - hlen, skb->len + hlen))
+            BUG();
         nskb->dev = skb->dev;
         nskb->proto_csum_valid = skb->proto_csum_valid;
         dev_kfree_skb(skb);